Move disk and memory metrics in custom group to compute #1024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/XS
|
/retest |
|
Looking at the description of #825: /lgtm CC @kasbert |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chrishenzie, wangzhen127 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/retest |
aojea
pushed a commit
to aojea/kubernetes
that referenced
this pull request
Jul 24, 2025
https://gke-internal.googlesource.com/kubernetes/node-problem-detector/+log/f6bb4f7b5506e8bc9cb8b8e2b1c7ef009fa628c0 This NPD version contains the following 2 changes needed: - High CVE fix: kubernetes/node-problem-detector#1035 - Custom metrics fix: kubernetes/node-problem-detector#1024 This NPD version is promoted at https://critique.corp.google.com/cl/736379160 ``` $ gsutil cp "gs://gke-release-staging/node-problem-detector/node-problem-detector-v0.8.20-71-gf6bb4f7b-gke.0*tar.gz.sha512" . $ cat * 254af832178eafa4666722b507a2556f331798c84fe9dcb9105c518d0842c13fc6f9f1fb297fe5ffa1f4656a6bfe1b6cd396175d9e2c748e3e9c6d092706bfaa node-problem-detector-v0.8.20-71-gf6bb4f7b-gke.0-linux_amd64.tar.gz 0e2680ad176aa745c4f68f3bdf6bdd59c3d193c6605cbeb4b0192e4bc34c2d9240f6738090111d8bbfc2d7a016ee9854f02c8eaa8c7cb1543a8fe5951be0bd7a node-problem-detector-v0.8.20-71-gf6bb4f7b-gke.0-linux_arm64.tar.gz 81e89cf9f7af0be608d9b432afb9b76ab11792d143b8529d2600bd3d9276c3b78c9548fd179f43b9626f38c115b6b0fa906f2927d72314457b4faca68b1c636e node-problem-detector-v0.8.20-71-gf6bb4f7b-gke.0-windows_amd64.tar.gz ``` BUG: 384629347 BUG: 394504964 Change-Id: Ied5cb95672bf906c339561282899d24bf311a645
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As far as I understand these metrics should be part of
compute.googleapis.com.